Tracking contents of both hands

Sduibek

Sduibek

Creator of Fallout Fixt
Moderator
Modder
Can this be done? All the stuff below could of course apply to lots of things other than lit flares.

For example:
1. Know that the player is holding XYZ in the active slot.
2. Know that the player is also holding a Lit Flare in the inactive hand.

As far as I am aware, vanilla engine always clears the off-hand data, so its contents are 0 and PID is -1.

I'd like to have a way to essentially be holding a flare along with a gun/holodisk/whatever, and have the light radius still be added as if you were actively holding the flare.

Currently to have this off-hand lightsource functionality we have to allow the light radius to be added with a lit flare anywhere in inventory, which I think is kind of stupid/unrealistic.

-IDEAS/CONCERNS-

#1: Obviously we'd have to track if either item is two-handed, and if so, the item or both items would be greyed out and unusable, and/or not apply their usual effects.

#2: For the two-handed case above, they could either go back to inventory or be dropped to the ground instead of being greyed-out.

#3: What about using a global variable as a pointer to track the item's location? So attach the item to a script and the script would have something like:

Code: 
flare.ssl
if   has_obj(dude, self_pointer_GVAR)  &&  (active_hand_contents == self_pointer_GVAR) // only run if you're actively holding the item
    set_light_level(dude, 100)
end
 
Last edited:
you can use the inventorymove hook to track all inventory changes, and removeinvenobj all item drops/throws, so with those combined you can relatively easily track what's in both hands indirectly (I'll see if I have an example somewhere tomorrow).
 
This kinda fits my question too... I feel rather confused right now, so I am happy if someone can lend me a hand here.

How would it be done if I want to save the currently equipped armor + item in the left and right hand.... then I remove the items (easy part), and after that, give the items back to the player- with the armor getting back into the armor slot, the weapon 1 and 2 getting back into the hand slots.

Tried a little bit with that yesterday, but the best I've made was a game crashing back to desktop.
 
Hmmm, seems I was being too cocky (kid). inventory movement can be tracked just fine, but item dropping seems unsolvable to me. The issue is how you can tell whether something that's being dropped is in the off-hand or in the backpack (keep in mind that, given the changing object pointers, the only thing you can save is PID's, so the issue would strictly be if someone dropped something which exists as a PID both in the backpack and in the off-hand). Given that removeinvenobj gets called after the drop has already taken place, it seems to me to be insurmountable... I guess you could try something like constantly rebuild an array of all object pointers in the inventory to find the off-hand one by elimination (you'd have to do so constantly, to account for stuff like stacking), but that seems like overkill.

Only method I have so far is very inelegant:

Code: 
procedure check_off_hand begin
   variable off_hand:=0;
   toggle_active_hand;
   if active_hand == left_hand_is then
      off_hand:=critter_inven_obj(dude_obj, INVEN_TYPE_LEFT_HAND);
   else
      off_hand:=critter_inven_obj(dude_obj, INVEN_TYPE_RIGHT_HAND);
   toggle_active_hand;
   return off_hand;
end

This gives you the object pointer nice and easy, but also causes a brief unequip animation I don't think you can eliminate (e.g. clear_anim just causes you to be stuck with the frame carrying the offhand weapon).

Lexx said:
This kinda fits my question too... I feel rather confused right now, so I am happy if someone can lend me a hand here.

How would it be done if I want to save the currently equipped armor + item in the left and right hand.... then I remove the items (easy part), and after that, give the items back to the player- with the armor getting back into the armor slot, the weapon 1 and 2 getting back into the hand slots.

Tried a little bit with that yesterday, but the best I've made was a game crashing back to desktop.
Click to expand...

This should do what you want to do:

Code: 
    wield_obj_critter(dude_obj, armor);
    wield_obj_critter(dude_obj, slot_1);
    toggle_active_hand;
    wield_obj_critter(dude_obj, slot_2);

You probably already did something more or less like this, but the fact that it's crashing would seem to indicate that you're either trying to wield something that doesn't exist, or something that isn't in the dude's inventory at that moment, so I'd try out some debug messages checking for the objects' location/existence if the problem persists.
 
Ok, I'm fairly sure this is the best I can do:

Code: 
procedure start begin
   variable tmp, tmp_two;
   variable obj, objs;
   variable counter, counter_two, global_dude_tile;
  if game_loaded then begin
    register_hook_proc(HOOK_REMOVEINVENOBJ, removeinvenobj);
    set_global_script_type(1);
    set_global_script_repeat(1);
    inventory_once:=1;
  end else begin
      if (get_game_mode BWAND INVENTORY) > 0 then begin
         if inventory_once == 0 then begin
            inventory_once:=1;
         end
         if inventory_once == 2 then
            inventory_once:=0;
      end else begin
         if inventory_once == 1 then begin
            tap_key(I_key);
            tap_key(Escape_key);
            inventory_once:=2;
         end
      end
  end
end


procedure map_enter_p_proc begin
    inventory_once:=1;
end



procedure removeinvenobj begin
   variable critter:=get_sfall_arg;
   variable item:=get_sfall_arg;
   variable number:=get_sfall_arg;
   variable reason:=get_sfall_arg;
   //variable obj_left_hand;
   display_msg("reason " + reason + " item " + obj_name(item));
   if reason == left_hand_equiped then begin
      set_sfall_global("dudeobjl", item);
   end else if reason == right_hand_equiped then begin
      set_sfall_global("dudeobjr", item);
   end
   if reason == drop_item or reason == item_removed or reason == item_destroyed or reason == use_or_drop_live_dynamite or reason == RMOBJ_THROW then begin
      if not obj_is_carrying_obj(dude_obj, item) then begin    //need to rule out dynamite use without dropping
         if item == get_sfall_global_int("dudeobjl") then begin
            set_sfall_global("dudeobjl", -1);
         end else if item == get_sfall_global_int("dudeobjr") then begin
            set_sfall_global("dudeobjr", -1);
         end
      end
   end  
end


The system is based on the fact that there's simply only one point in time in which the off hand is actually recorded, namely when removeinvenobj gets called during inventory opening to "remove" the objects in your hands and armor slots to some mystical place where they can be properly displayed. So, by opening and closing the inventory at, um, a couple of moments (after closing the inventory, after map entry, and after map load) you get accurate object pointers to the on- and off-hand throughout the game (as long as drops/removals are also tracked).

It's still very inelegant, (and you'd need to set the inventory AP cost to 0 briefly as well to let you do it during combat) but it is what it is.

Edit: If you happen to want to compile it but can't, use the jims_define_extra header in this download.
 
Last edited:
You must log in or register to reply here.
Back
Top